[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 01/12] client rpc: Improve debug messages in virNetClientIO



When analyzing our debug log, I'm always confused about what each of the
pointers mean. Let's be explicit.
---
 src/rpc/virnetclient.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index 14f806f..c62e045 100644
--- a/src/rpc/virnetclient.c
+++ b/src/rpc/virnetclient.c
@@ -1567,7 +1567,8 @@ static int virNetClientIO(virNetClientPtr client,
             return -1;
         }
 
-        VIR_DEBUG("Going to sleep %p %p", client->waitDispatch, thiscall);
+        VIR_DEBUG("Going to sleep head=%p call=%p",
+                  client->waitDispatch, thiscall);
         /* Go to sleep while other thread is working... */
         if (virCondWait(&thiscall->cond, &client->lock) < 0) {
             virNetClientCallRemove(&client->waitDispatch, thiscall);
@@ -1576,7 +1577,8 @@ static int virNetClientIO(virNetClientPtr client,
             return -1;
         }
 
-        VIR_DEBUG("Wokeup from sleep %p %p", client->waitDispatch, thiscall);
+        VIR_DEBUG("Woken up from sleep head=%p call=%p",
+                  client->waitDispatch, thiscall);
         /* Three reasons we can be woken up
          *  1. Other thread has got our reply ready for us
          *  2. Other thread is all done, and it is our turn to
@@ -1608,7 +1610,8 @@ static int virNetClientIO(virNetClientPtr client,
         client->haveTheBuck = true;
     }
 
-    VIR_DEBUG("We have the buck %p %p", client->waitDispatch, thiscall);
+    VIR_DEBUG("We have the buck head=%p call=%p",
+              client->waitDispatch, thiscall);
 
     /*
      * The buck stops here!
@@ -1637,7 +1640,8 @@ static int virNetClientIO(virNetClientPtr client,
         rv = -1;
 
 cleanup:
-    VIR_DEBUG("All done with our call %p %p %d", client->waitDispatch, thiscall, rv);
+    VIR_DEBUG("All done with our call head=%p call=%p rv=%d",
+              client->waitDispatch, thiscall, rv);
     return rv;
 }
 
-- 
1.7.10.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]