[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] domain: fix the main function name to be consistent with file name



On 2012年06月13日 14:53, Wanlong Gao wrote:
> The main function name should be consistent with the file's
> basename.
> 
> Signed-off-by: Wanlong Gao<gaowanlong cn fujitsu com>
> ---
>   repos/domain/domain_blkinfo.py | 2 +-
>   repos/domain/domain_id.py      | 2 +-
>   repos/domain/domain_name.py    | 2 +-
>   repos/domain/domain_uuid.py    | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/repos/domain/domain_blkinfo.py b/repos/domain/domain_blkinfo.py
> index 6b65e23..b6051aa 100644
> --- a/repos/domain/domain_blkinfo.py
> +++ b/repos/domain/domain_blkinfo.py
> @@ -77,7 +77,7 @@ def check_block_data(blockdev, blkdata, logger):
>       return 0
> 
> 
> -def domblkinfo(params):
> +def domain_blkinfo(params):
>       """ using du command to check the data
>           in the output of virsh domblkinfo
>       """
> diff --git a/repos/domain/domain_id.py b/repos/domain/domain_id.py
> index bc573f9..b4cc5d1 100644
> --- a/repos/domain/domain_id.py
> +++ b/repos/domain/domain_id.py
> @@ -39,7 +39,7 @@ def check_domain_exists(conn, guestname, logger):
>       else:
>           return True
> 
> -def domid(params):
> +def domain_id(params):
>       """check virsh domid command
>       """
>       logger = params['logger']
> diff --git a/repos/domain/domain_name.py b/repos/domain/domain_name.py
> index 0033648..ebf99c4 100644
> --- a/repos/domain/domain_name.py
> +++ b/repos/domain/domain_name.py
> @@ -22,7 +22,7 @@ def get_output(logger, command):
>           logger.error(ret)
>       return status, ret
> 
> -def domname(params):
> +def domain_name(params):
>       """check virsh domname command
>       """
>       logger = params['logger']
> diff --git a/repos/domain/domain_uuid.py b/repos/domain/domain_uuid.py
> index 1c4ed77..299cba4 100644
> --- a/repos/domain/domain_uuid.py
> +++ b/repos/domain/domain_uuid.py
> @@ -48,7 +48,7 @@ def check_domain_uuid(guestname, UUIDString, logger):
>           else:
>               return False
> 
> -def domuuid(params):
> +def domain_uuid(params):
>       """check virsh domuuid command
>       """
>       logger = params['logger']

Good fix, ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]