[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Report name from edited object



On 06/14/2012 06:50 AM, Michal Privoznik wrote:
> There is a little easter egg in virsh: one can easily clone
> an object (domain, network, ...). Just 'virsh edit' change the name
> and remove <uuid>. And then, in the end when reporting success
> the new name was printed out.
> However, with recent edit rewrite we lost the final part and are
> still printing the original name out.
> ---
> Or even better - if name changes, we can choose better message,
> something like "New domain %s defined". But I am not sure
> we want to expose this easter egg to users.

Yeah, I ran into some of that fun when implementing snapshot-edit.

I think your patch goes far enough; printing the final name is good
enough, without having to try and produce a smarter output message.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]