[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] virsh: Honor reedit opts printing to a function



On 14.06.2012 11:22, Peter Krempa wrote:
> On 06/14/12 11:07, Michal Privoznik wrote:
>> When printing reedit options we make stdin raw. However,
>> this results in stdout being raw as well. Therefore we need
>> to return carriage when doing new line. Unfortunately,
>> '\r' cannot be part of internationalized messages hence
>> we must move them to formatting string which then in turn
>> become huge and disarranged. To solve this, a new function
>> is introduced which takes variable string arguments and
>> prepend each with "\r\n" just before printing.
> 
> s/prepend/appends/, s/just before/after/
> 
>> ---
> 
> ACK as you precisely followed Eric's suggestions.
> 
> Peter

AAgrh, I forgot to fix commit message before pushing. Sorry.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]