[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Improve error message diagnosing incorrect XML CPU mode



From: "Daniel P. Berrange" <berrange redhat com>

Tell the user what CPU mode value is wrong
---
 src/conf/cpu_conf.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 018d571..b520f7c 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -234,13 +234,15 @@ virCPUDefParseXML(const xmlNodePtr node,
             goto error;
         } else {
             def->mode = virCPUModeTypeFromString(cpuMode);
-            VIR_FREE(cpuMode);
 
             if (def->mode < 0) {
-                virCPUReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                                  _("Invalid mode attribute"));
+                virCPUReportError(VIR_ERR_INTERNAL_ERROR,
+                                  _("Invalid mode attribute '%s'"),
+                                  cpuMode);
+                VIR_FREE(cpuMode);
                 goto error;
             }
+            VIR_FREE(cpuMode);
         }
     } else {
         if (def->type == VIR_CPU_TYPE_HOST)
-- 
1.7.10.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]