[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] add handling EINTR to test example of event loop



On Mon, Jun 18, 2012 at 03:20:52PM +0800, Royce Lv wrote:
> some system calls and signal will interrupt
> poll,
> making event loop stops and fails to react events and keepalive
> message
> from
> libvirt.
> adding handling EINTR to poll to make it more
> robust
> 
> 
> Signed-off-by: lvroyce <lvroyce linux vnet ibm com>
> 
> ---
> 
>  examples/domain-events/events-python/event-test.py |    8
> +++++++-
>  1 files changed, 7 insertions(+), 1
> deletions(-)
> 
> 
> diff --git a/examples/domain-events/events-python/event-test.py
> b/examples/domain-events/events-python/event-test.py
> index 96dc268..b446c21
> 100644
> ---
> a/examples/domain-events/events-python/event-test.py
> +++
> b/examples/domain-events/events-python/event-test.py
> @@ -188,7 +188,13 @@ class
> virEventLoopPure:
>                  sleep = (next - now) /
> 1000.0
> 
> 
>          debug("Poll with a sleep of %d" %
> sleep)
> -        events =
> self.poll.poll(sleep)
> +
> try:
> +            events =
> self.poll.poll(sleep)
> +        except select.error,
> e:
> +                self.runningPoll =
> False
> +                if not e.errno in (errno.EINTR,
> errno.EAGAIN):
> +
> raise
> +
> return
> 
> 
>          # Dispatch any file handle events that
> occurred
>          for (fd, revents) in
> events:

Unfortunately your email client has totally scrambled the patch.
Can you fix it & resend, or even better use  'git send-email'
to avoid these kind of problems with broken email clients.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]