[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] virsh: Update vol-create-as manpage



On 06/18/2012 05:52 AM, Osier Yang wrote:

>> specify the volume
>> -file format to use; raw, bochs, qcow, qcow2, vmdk.
>> +file format to use; raw, bochs, qcow, qcow2, vmdk, qed.
>>   I<--backing-vol>  I<vol-name-or-key-or-path>  is the source backing
>>   volume to be used if taking a snapshot of an existing volume.
>>   I<--backing-vol-format>  I<string>  is the format of the snapshot
>> backing volume;
>> -raw, bochs, qcow, qcow2, vmdk, host_device.
>> +raw, bochs, qcow, qcow2, vmdk, qed, host_device.
>>
>>   =item B<vol-clone>  [I<--pool>  I<pool-or-uuid>]
>> I<vol-name-or-key-or-path>
>>   I<name>
> 
> Looks fine, but rng and virsh help need to update too. And it's better
> to mention it's for file based storage pools.

You can use qcow2 on top of an LVM volume, so it is not just file based
storage pools.  Also, the rng right now takes a free-form string.  It
might be nice to polish the code into enumerating the exact values that
we support instead of being free-form, but that's a bigger project.  But
yes, it means that our documentation is now chasing qemu because our rng
is letting the free-form text through to be interpreted by qemu.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]