[libvirt] pool-create/pool-create-as should include build pool then start?

[Zhimou Peng]

Well, that's my pool xml:

https://bugzilla.redhat.com/attachment.cgi?id=590335
https://bugzilla.redhat.com/attachment.cgi?id=590336
https://bugzilla.redhat.com/attachment.cgi?id=590337

Yes, i agree with you, i think we should support option like --build.

BR
zhpeng
----- Original Message -----
From: "Eric Blake" <eblake at redhat.com>
To: "Zhimou Peng" <zhpeng at redhat.com>
Cc: libvir-list at redhat.com
Sent: Tuesday, June 19, 2012 12:27:20 AM
Subject: Re: [libvirt] pool-create/pool-create-as should include build pool then start?

On 06/18/2012 03:12 AM, Zhimou Peng wrote:
> Hi all,
> 
> According to https://bugzilla.redhat.com/show_bug.cgi?id=830056#c5, i think we should talk about this:
> 
> Description
> If pool environment is not built, pool-create/pool-create-as will always fail.
> I think pool-create should build the pool.
> 
> Version
> qemu-kvm-0.12.1.2-2.295.el6.x86_64
> kernel-2.6.32-276.el6.x86_64
> libvirt-0.9.10-21.el6.x86_64
> 
> Steps
> For example:
> dir pool
> virsh # pool-create dirpool.xml 
> error: Failed to create pool from dirpool.xml
> error: cannot open path '/var/lib/libvirt/dir': No such file or directory

What are the contents of dirpool.xml?

I think that it might make sense to add a new option to pool-create[-as]
to additional build the pool; but I think it needs to be an explicit
option rather than the default behavior, so that we don't break
back-compat.  Maybe:

pool-create --build dirpool.xml

being what you would use to build as well as start the directory pool
mentioned in your xml.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org