[libvirt] [sandbox][PATCH] Add module directory prefix selection feature

Radu Caragea sinaelgl at gmail.com
Tue Jun 19 15:48:51 UTC 2012


On Tue, Jun 19, 2012 at 6:31 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> I tend to think it would be more flexible, if instead of just the prefix, we
> used the API to set the base module dir, eg
>
>   gvir_sandbox_config_initrd_set_moduledir("/lib/modules");
>   gvir_sandbox_config_initrd_set_moduledir("/some/other/prefix/lib/modules");
>   gvir_sandbox_config_initrd_set_moduledir("/some/other/dir")
>
> and then just append the version string to that.
>
> Daniel

Yes, I take your point. So basically the default moduledir should be
"/lib/modules", the moddirpath corrected and the functions renamed a
bit. But otherwise does it seem ok? I wasn't really sure about having
a setter function both for the config and the initrd.




More information about the libvir-list mailing list