[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] docs: update and fix search page



On 06/21/2012 12:28 PM, Daniel P. Berrange wrote:
> On Thu, Jun 21, 2012 at 12:18:13PM +0200, Martin Kletzander wrote:
>> Search page had old and shifted menu under the whole content. This
>> patch moves the menu before the content, which makes it appear
>> correctly as on other pages, and updates it to the newest look.
>> ---
>>  docs/search.php |   76 +++++++++++++++++++++++++++++++++++++-----------------
>>  1 files changed, 52 insertions(+), 24 deletions(-)
> 
> This is just replacing one set of hardcoded content with another
> set.
> 
> What is needed here is to rename it to search.php.in and then
> process it with the XSL templates as we do for all the other
> pages.
> 
> Daniel
> 

Yes, that definitely seems more logical and clean, I just didn't want to
change it that much. But if you're ok with that, I'll follow with v2 in
a moment.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]