[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/5] qemu: Implement virDomainInterfacesAddresses



On 06/21/12 15:56, Michal Privoznik wrote:
> ---
>   src/qemu/qemu_driver.c |   68 ++++++++++++++++++++++++++++++++++++++++++++++++
>   1 files changed, 68 insertions(+), 0 deletions(-)
> 
> +
>   static virDriver qemuDriver = {
>       .no = VIR_DRV_QEMU,
>       .name = QEMU_DRIVER_NAME,
> @@ -13322,6 +13389,7 @@ static virDriver qemuDriver = {
>       .domainPMSuspendForDuration = qemuDomainPMSuspendForDuration, /* 0.9.11 */
>       .domainPMWakeup = qemuDomainPMWakeup, /* 0.9.11 */
>       .domainGetCPUStats = qemuDomainGetCPUStats, /* 0.9.11 */
> +    .domainGetInterfacesAddresses = qemuDomainGetInterfacesAddresses, /* 0.9.13 */
>   };

In the driver struct you've ordered the function between similar functions but here's at the end.

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 6f53264..40a7a9c 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -5226,6 +5226,7 @@ static virDriver remote_driver = {
     .domainInterfaceStats = remoteDomainInterfaceStats, /* 0.3.2 */
     .domainSetInterfaceParameters = remoteDomainSetInterfaceParameters, /* 0.9.9 */
     .domainGetInterfaceParameters = remoteDomainGetInterfaceParameters, /* 0.9.9 */
+    .domainGetInterfacesAddresses = remoteDomainGetInterfacesAddresses, /* 0.9.13 */
     .domainMemoryStats = remoteDomainMemoryStats, /* 0.7.5 */
     .domainBlockPeek = remoteDomainBlockPeek, /* 0.4.2 */
     .domainMemoryPeek = remoteDomainMemoryPeek, /* 0.4.2 */


ACK with reordered driver struct initialization.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]