[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't install systemd service files executable



On 06/26/2012 02:26 AM, Guido Günther wrote:
> since they aren't. Detected by Debian's lintian.
> ---
>  daemon/Makefile.am |    2 +-
>  tools/Makefile.am  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/daemon/Makefile.am b/daemon/Makefile.am
> index fbb0ae1..473fa98 100644
> --- a/daemon/Makefile.am
> +++ b/daemon/Makefile.am
> @@ -319,7 +319,7 @@ BUILT_SOURCES += libvirtd.service
>  
>  install-init-systemd: install-sysconfig libvirtd.service
>  	$(MKDIR_P) $(DESTDIR)$(SYSTEMD_UNIT_DIR)
> -	$(INSTALL_SCRIPT) libvirtd.service \
> +	$(INSTALL_SCRIPT) -m0644 libvirtd.service \

NACK.

$(INSTALL_SCRIPT) implies executable.  If they are not executable, we
should be using $(INSTALL_DATA) instead.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]