[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] Don't install systemd service files executable



On Tue, Jun 26, 2012 at 02:40:09PM +0100, Daniel P. Berrange wrote:
> On Tue, Jun 26, 2012 at 03:34:47PM +0200, Guido Günther wrote:
> > since they aren't. Detected by Debian's lintian.
> > ---
> > Changes since last version: use INSTALL_DATA instead of -m0644
> > 
> >  daemon/Makefile.am |    2 +-
> >  tools/Makefile.am  |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/daemon/Makefile.am b/daemon/Makefile.am
> > index fbb0ae1..71e91cd 100644
> > --- a/daemon/Makefile.am
> > +++ b/daemon/Makefile.am
> > @@ -319,7 +319,7 @@ BUILT_SOURCES += libvirtd.service
> >  
> >  install-init-systemd: install-sysconfig libvirtd.service
> >  	$(MKDIR_P) $(DESTDIR)$(SYSTEMD_UNIT_DIR)
> > -	$(INSTALL_SCRIPT) libvirtd.service \
> > +	$(INSTALL_DATA) libvirtd.service \
> >  	  $(DESTDIR)$(SYSTEMD_UNIT_DIR)/libvirtd.service
> >  
> >  uninstall-init-systemd: uninstall-sysconfig
> > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > index 7ca5599..c82a2fb 100644
> > --- a/tools/Makefile.am
> > +++ b/tools/Makefile.am
> > @@ -198,7 +198,7 @@ SYSTEMD_UNIT_DIR = /lib/systemd/system
> >  if LIBVIRT_INIT_SCRIPT_SYSTEMD
> >  install-systemd: libvirt-guests.service install-initscript install-sysconfig
> >  	$(MKDIR_P) $(DESTDIR)$(SYSTEMD_UNIT_DIR)
> > -	$(INSTALL_SCRIPT) libvirt-guests.service \
> > +	$(INSTALL_DATA) libvirt-guests.service \
> >  	  $(DESTDIR)$(SYSTEMD_UNIT_DIR)/libvirt-guests.service
> >  
> >  uninstall-systemd: uninstall-initscript uninstall-sysconfig
> 
> ACK
Pushed. Thanks.
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]