[libvirt] [PATCH] virsh: Cleanup virsh -V output

Osier Yang jyang at redhat.com
Wed Jun 27 03:58:47 UTC 2012


On 2012年06月27日 02:31, Doug Goldstein wrote:
> Fixed up virsh -V output by removing invalid WITH_PROXY&  WITH_ONE
> checks, adding Hyper-V check and fixing the DTrace check.
>
> Signed-off-by: Doug Goldstein<cardoe at cardoe.com>
> ---
>   tools/virsh.c |    9 +++------
>   1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tools/virsh.c b/tools/virsh.c
> index 2b4cb2c..9fccd2d 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -20636,8 +20636,8 @@ vshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED)
>   #ifdef WITH_PHYP
>       vshPrint(ctl, " PHYP");
>   #endif
> -#ifdef WITH_ONE
> -    vshPrint(ctl, " ONE");
> +#ifdef WITH_HYPERV
> +    vshPrint(ctl, " Hyper-V");
>   #endif
>   #ifdef WITH_TEST
>       vshPrint(ctl, " Test");
> @@ -20648,9 +20648,6 @@ vshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED)
>   #ifdef WITH_REMOTE
>       vshPrint(ctl, " Remote");
>   #endif
> -#ifdef WITH_PROXY
> -    vshPrint(ctl, " Proxy");
> -#endif
>   #ifdef WITH_LIBVIRTD
>       vshPrint(ctl, " Daemon");
>   #endif
> @@ -20711,7 +20708,7 @@ vshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED)
>   #ifdef ENABLE_DEBUG
>       vshPrint(ctl, " Debug");
>   #endif
> -#ifdef WITH_DTRACE
> +#ifdef WITH_DTRACE_PROBES
>       vshPrint(ctl, " DTrace");
>   #endif
>   #ifdef USE_READLINE

Good fixes, but WITH_LIBXL is also missed, better to add
it in together.

Regards,
Osier




More information about the libvir-list mailing list