[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/17] conf: add missing device types to virDomainDevice(Type|Def)



On 02/28/2012 01:14 PM, Laine Stump wrote:
> Not all device types were represented in virDomainDeviceType, so some
> types of devices couldn't be represented in a virDomainDeviceDef
> (which requires a different type of pointer in the union for each
> different kind of device).
> 
> Since serial, parallel, channel, and console devices are all
> virDomainChrDef, and the virDomainDeviceType is never used to produce
> a string from the type (and only used in the other direction
> internally to code, never to produce XML), I only added one "CHR"
> type, which is associated with "virDomainChrDefPtr chr" in the union.
> ---
> New patch in V2.
> 
>  src/conf/domain_conf.c |    6 +++++-
>  src/conf/domain_conf.h |   11 +++++++++--
>  2 files changed, 14 insertions(+), 3 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]