[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] blockResize: add flag for bytes



On 03/03/2012 09:48 AM, Eric Blake wrote:
> Qemu supports sizing by bytes; we shouldn't force the user to
> round up if they really wanted an unaligned total size.
>
> * include/libvirt/libvirt.h.in (VIR_DOMAIN_BLOCK_RESIZE_BYTES):
> New flag.
> * src/libvirt.c (virDomainBlockResize): Document it.
> * src/qemu/qemu_monitor_json.c (qemuMonitorJSONBlockResize): Take
> size in bytes.
> * src/qemu/qemu_monitor_text.c (qemuMonitorTextBlockResize):
> Likewise.  Pass bytes, not megabytes, to monitor.
> * src/qemu/qemu_driver.c (qemuDomainBlockResize): Implement new
> flag.
> ---

Looks okay to me. ACK.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]