[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: eliminate crash in virNetDevMacVLanCreateWithVPortProfile



On 05.03.2012 20:42, Laine Stump wrote:
> From: root <root vlap laine org>
> 
> Commit 723d5c (added after the release of 0.9.10) adds a
> NetlinkEventClient for each interface sent to
> virNetDevMacVLanCreateWithVPortProfile. This should only be done if
> the interface actually *has* a virtPortProfile, otherwise the event
> handler would be a NOP. The bigger problem is that part of the setup
> to create the NetlinkEventClient is to do a memcpy of virtPortProfile
> - if it's NULL, this triggers a segv.
> 
> This patch just qualifies the code that adds the client - if
> virtPortProfile is NULL, it's skipped.
> ---
>  src/util/virnetdevmacvlan.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

ACK


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]