[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4 v3] qemu_hostdev: Add support to install port profile and mac address on hostdevs



On 03/05/2012 08:12 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roprabhu cisco com>
>
> These changes are applied only if the hostdev has a parent net device.
> If the parent netdevice has virtual port information, the original virtualport
> associate functions are called (these set and restore both mac and port profile
> on an interface). Else, only mac address is set on the device
> using other methods depending on if its a sriov device or not.
>
> Changes also include hotplug pci devices
>
> Signed-off-by: Roopa Prabhu <roprabhu cisco com>
> ---
>  src/qemu/qemu_hostdev.c |  241 +++++++++++++++++++++++++++++++++++++++++++++--
>  src/qemu/qemu_hostdev.h |    8 +-
>  src/qemu/qemu_hotplug.c |   10 ++
>  3 files changed, 246 insertions(+), 13 deletions(-)
>
>
> diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
> index b3cad8e..ebcdc52 100644
> --- a/src/qemu/qemu_hostdev.c
> +++ b/src/qemu/qemu_hostdev.c
> @@ -29,6 +29,13 @@
>  #include "memory.h"
>  #include "pci.h"
>  #include "hostusb.h"
> +#include "virnetdev.h"
> +
> +VIR_ENUM_IMPL(virNetDevVPort, VIR_NETDEV_VPORT_PROFILE_LAST,
> +              "none",
> +              "802.1Qbg",
> +              "802.1Qbh",
> +              "openvswitch")
>  

Oops. I didn't notice this until I got to the final build test before
pushing - VIR_ENUM_IMPL defines global functions, so you can't define it
twice for the same type. Instead, just export the xxxToString and
xxxFromString functions in libvirt_private.syms.

I'm squashing that change into the commit.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]