[libvirt] [PATCHv2 04/15] xml: share 'unit' in RNG

Peter Krempa pkrempa at redhat.com
Tue Mar 6 13:52:30 UTC 2012


On 03/06/2012 01:34 AM, Eric Blake wrote:
> The code supported unit='E' for "exabyte", but the RNG did not;
> conversely, the RNG supported "z" and "y" but the code did not
> (I'm jealous if you have that much storage, particularly since
> it won't fit in 64-bit off_t).  Also, the code supported
> <allocation unit='...'>, but not the RNG.
>
> In an effort to make 'unit' more worthwhile in future patches,
> it's easier to share it between files.
>
> In making this factorization, note that absFilePath is more
> permissive than 'path', so storage pools and storage volumes
> will now validate with a wider set of file names than before.
> I don't think this should be a problem in practice.
>
> * docs/schemas/storagepool.rng: Include basic types, rather than
> repeating things here.
> * docs/schemas/storagevol.rng: Likewise.
> * docs/schemas/basictypes.rng: Add 'unsignedLong', 'unit', and fix
> to match storage code.
> ---

There are more places that can be simplified including the 
basictypes.rng file. I'll post a separate patch for them.

ACK,

Peter




More information about the libvir-list mailing list