[libvirt] [libvirt-glib] Keep domain devices list sorted

Zeeshan Ali (Khattak) zeeshanak at gnome.org
Tue Mar 6 23:56:44 UTC 2012


On Wed, Mar 7, 2012 at 1:03 AM, Eric Blake <eblake at redhat.com> wrote:
> On 03/06/2012 03:27 PM, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>>
>> While we don't guarantee the order of devices in the list returned from
>> gvir_domain_get_devices(), its not a bad idea to keep them sorted the
>> same way we get them from configuration (XML).
>
> Actually, if I understand things right, preserving order _is_ important
> to guarantee.  For example, with older XML that lacked per-device <boot
> order='n'/>, libvirt would determine which order devices are presented
> to guest BIOS boot order based on their position within XML.

Well, I agree. You only need to convince Christophe on this. :)

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124




More information about the libvir-list mailing list