[libvirt] [PATCHv2 11/15] virsh: add option aliases

Peter Krempa pkrempa at redhat.com
Wed Mar 7 13:17:19 UTC 2012


On 03/06/2012 01:34 AM, Eric Blake wrote:
> In the past, we have created some virsh options with less-than-stellar
> names.  For back-compat reasons, those names must continue to parse,
> but we don't want to document them in help output.  This introduces
> a new option type, an alias, which points to a canonical option name
> later in the option list.
>
> I'm actually quite impressed that our code has already been factored
> to do all option parsing through common entry points, such that I
> got this added in relatively few lines of code!
>
> * tools/virsh.c (VSH_OT_ALIAS): New option type.
> (opts_echo): Hook up an alias, for easy testing.
> (vshCmddefOptParse, vshCmddefHelp, vshCmddefGetOption): Allow for
> aliases.
> * tests/virshtest.c (mymain): Test new feature.
> ---

As a side note: It would be the best with this change to put a warning 
into the mang page that options that disappeared from the help/man page 
are not vanished but are obsolete and the user should use the new 
spellings but we still support the legacy ones.

Peter




More information about the libvir-list mailing list