[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Use option alias for outmoded "--persistent"



On 03/07/2012 03:17 AM, Osier Yang wrote:
> Since VIR_DOMAIN_AFFECT_{LIVE,CONFIG,CURRENT} was created,
> all new virsh commands use "--config" to represents the
> persistent changing. This patch add "--config" option
> for the old commands which still use "--persistent",
> and "--persistent" is now alias of "--config".
> 
> tools/virsh.c: (use "--config", and "--persistent" is
>     alias of "--config" now).
>     cmdDomIfSetLink, cmdDomIfGetLink, cmdAttachDevice,
>     cmdDetachDevice, cmdUpdateDevice, cmdAttachInterface,
>     cmdDetachInterface, cmdAttachDisk, cmdDetachDisk
> 
> toos/virsh.pod: Update docs of the changed commands, and
>     add some missed docs for "--config" (detach-interface,
>     detach-disk, and detach-device).
> ---
>  tools/virsh.c   |   51 ++++++++++++++++++++++++++++++---------------------
>  tools/virsh.pod |   36 ++++++++++++++++++++++--------------
>  2 files changed, 52 insertions(+), 35 deletions(-)

The code looks fine.

Per the previous patches, we should document in virsh.pod that older
versions of virsh understood --persistent, so it's probably worth a v2
to make sure we like the docs.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]