[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remove daemon/probes.h from .gitignore



On 03/08/2012 04:59 PM, Eric Blake wrote:
> On 03/08/2012 02:53 PM, Laine Stump wrote:
>> The file daemon/probes.h used to be generated as part of a build, but
>> is no longer used. However, a stale copy of it lying around could
>> cause a build to fail. Removing it from .gitignore will make it more
>> likely someone will notice that they have it lying around.
>> ---
>>
>> Although this is a very simple change, I haven't used the trivial rule
>> to push it, just to make sure everyone notices it, and nobody
>> accidentally adds the file to git with "git add .".
> If you have a long-lived tree, or plan on swapping to old commits prior
> to the point where we renamed things, I recommend doing:
>
> echo /daemon/probes.h >> .git/info/exclude
>
> then you will be immune from 'git add .' accidentally re-adding it.
>
> Fresh checkouts are immune, and with this message serving as notice, I
> think we're okay.
>
> ACK.
>

And pushed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]