[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: eliminate redundant VIR_ALLOC of 1st element of network DNS hosts.



On 09.03.2012 10:03, Laine Stump wrote:
> virNetworkDNSHostsDefParseXML was calling VIR_ALLOC(def->hosts) if
> def->hosts was NULL. This is a waste of time, though, since
> VIR_REALLOC_N is called a few lines further down, prior to any use of
> def->hosts. (initializing def->nhosts to 0 is also redundant, because
> the newly allocated memory will always be cleared to all 0's anyway).
> ---
>  src/conf/network_conf.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
> 

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]