[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/9] docs: Add documentation for new attribute tray of disk target



On Mon, Mar 05, 2012 at 06:25:40PM +0800, Osier Yang wrote:
> Example XML:
> 
>     <disk type='file' device='cdrom'>
>       <driver name='qemu' type='raw'/>
>       <source file='/tmp/cdrom.img'/>
>       <target dev='hdd' bus='ide' tray='open'/>
>     </disk>
> ---
>  docs/formatdomain.html.in     |   13 +++++++++----
>  docs/schemas/domaincommon.rng |    8 ++++++++
>  2 files changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index a61895f..158bafa 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -1091,7 +1091,7 @@
>      &lt;/disk&gt;
>      &lt;disk type='block' device='cdrom'&gt;
>        &lt;driver name='qemu' type='raw'/&gt;
> -      &lt;target dev='hdc' bus='ide'/&gt;
> +      &lt;target dev='hdc' bus='ide' tray='open'/&gt;
>        &lt;readonly/&gt;
>      &lt;/disk&gt;
>      &lt;disk type='block' device='lun'&gt;
> @@ -1202,10 +1202,15 @@
>          possible values are driver specific, with typical values being
>          "ide", "scsi", "virtio", "xen", "usb" or "sata". If omitted, the bus
>          type is inferred from the style of the device name. eg, a device named
> -        'sda' will typically be exported using a SCSI bus.
> +        'sda' will typically be exported using a SCSI bus. The optional
> +        attribute <code>tray</code> indicates the tray status of the
> +        removable disks (i.e. CDROM or Floppy disk), the value can be either
> +        "open" or "closed", defaults to "closed". NB, the value of
> +        <code>tray</code> could be updated while the domain is running.
>          <span class="since">Since 0.0.3; <code>bus</code> attribute since 0.4.3;
> -        "usb" attribute value since after 0.4.4; "sata" attribute value since
> -        0.9.7</span></dd>
> +        <code>tray</code> attribute since 0.9.11; "usb" attribute value since
> +        after 0.4.4; "sata" attribute value since 0.9.7</span>
> +      </dd>
>        <dt><code>iotune</code></dt>
>        <dd>The optional <code>iotune</code> element provides the
>          ability to provide additional per-device I/O tuning, with
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 3908733..e1e1027 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -959,6 +959,14 @@
>            </choice>
>          </attribute>
>        </optional>
> +      <optional>
> +        <attribute name="tray">
> +          <choice>
> +            <value>open</value>
> +            <value>closed</value>
> +          </choice>
> +        </attribute>
> +      </optional>
>      </element>
>    </define>
>    <!--

  Looks fine to me, ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]