[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/9] qemu: Do not start with source for removable disks if tray is open



Il 05/03/2012 11:25, Osier Yang ha scritto:
> This is similiar with physical world, one will be surprised if the
> box starts with medium exists while the tray is open.
> 
> New tests are added, tests disk-{cdrom,floppy}-tray are for the qemu
> supports "-device" flag, and disk-{cdrom,floppy}-no-device-cap are
> for old qemu, i.e. which doesn't support "-device" flag.

If the disk type is "block", and the source drive is a CD-ROM, the
virtual tray state should be tied to the physical tray, even though this
isn't always the case due to QEMU bugs.

Perhaps you should fail creation if the tray attribute is "open" in the
above circumstances.  Another possibility is to forbid specifying the
tray attribute completely.

Or you can just drop this patch, and only print the tray state in the
virsh dumpxml output.  There are other attributes that already handled
this way.

Paolo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]