[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 8/9] qemu: Update domain status to paused while suspend event is emitted



On 03/05/2012 03:25 AM, Osier Yang wrote:
> This introduces a new paused reason VIR_DOMAIN_PAUSED_SUSPEND,
> and new suspend event type VIR_DOMAIN_EVENT_SUSPENDED_SUSPEND.
> 
> While a SUSPEND event occurs, the running domain status will be
> transferred to "paused" with reason "VIR_DOMAIN_PAUSED_SUSPEND",
> and a new domain lifecycle event emitted with type
> VIR_DOMAIN_EVENT_SUSPENDED_SUSPEND.

NACK.

VIR_DOMAIN_EVENT_SUSPENDED_* is reserved for events where the domain is
in a paused state, due to virDomainSuspend.

We need a _new_ state (perhaps named pmsuspend), along with a new prefix
for events that move us into this new state (so far, we know of
guest-agent S3 requests that move us into this state, and pmwakeup that
moves us out of this state), since the state is very much distinct from
libvirt's notion of suspended (which really means paused).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]