[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] graphics: Cleanup port policy

On 03/12/2012 10:06 AM, Michal Privoznik wrote:
> Even though we say in documentation setting (tls-)port to -1 is legacy
> compat style for enabling autoport, we're roughly doing this for VNC.
> However, in case of SPICE auto enable autoport iff both port & tlsPort
> are equal -1 as documentation says autoport plays with both.
> ---
>  src/conf/domain_conf.c  |   30 ++++++++++++++++++++----------
>  src/conf/domain_conf.h  |    5 +++++
>  src/qemu/qemu_command.c |    2 +-
>  src/qemu/qemu_process.c |   33 ++++++++++++++++++++-------------
>  4 files changed, 46 insertions(+), 24 deletions(-)

ACK.  I had to look up the existing docs, which indeed state:

              Starts a SPICE server. The <code>port</code> attribute
              specifies the TCP port number (with -1 as legacy syntax
              indicating that it should be auto-allocated),
              while <code>tlsPort</code> gives an alternative secure
              port number. The <code>autoport</code> attribute is the
              new preferred syntax for indicating autoallocation of
              both port numbers.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]