[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc



On Tue, Mar 13, 2012 at 06:37:04PM +0100, Christophe Fergeau wrote:
> On Tue, Mar 13, 2012 at 05:01:14PM +0100, Marc-André Lureau wrote:
> > How do you verify new_from_xml()? Am I missing something?
> 
> This is just copy and paste, and keeping all files consistent. I don't
> think we have any user of these methods, except the top level ones, and I'm
> not sure it's really useful to be able to generate config objects from xml
> fragments. So basically it's boilerplate for now and not really useful.
> Maybe I should kill all these funcs some day...

It might be useful when you get into the realm of hotplug, since the
virDomain{Attach,Update,Detach}Device APIs use XML fragments for
just the invididual devices.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]