[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] python: add virDomainGetCPUStats python binding API



On 03/14/2012 03:02 AM, Daniel Veillard wrote:
> On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
>> On 03/14/2012 01:57 PM, Guannan Ren wrote:
>>>    dom.cPUStats(True, 0)
>> I'd like getVcpuStats or cpuStats function naming.
> 
>   Based on existing conventions, it should be getVcpuStats() method,

getVcpuStats is wrong - if flags is 0, we are getting stats on the
physical cpu of the host, not the vcpu of the guest.

I think we want getCpuStats.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]