[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Using Libvirt to change the bridge a virtual network card of a running vm is connected to



On 01/26/2012 04:10 AM, Daniel P. Berrange wrote:
> On Wed, Jan 25, 2012 at 04:09:22PM +0100, Hendrik Schwartke wrote:
>> I wrote a patch to change the mapping between a virtual bridge
>> interface and the host bridge while the host is up. It's based on
>> commit 6fba577e505611e6c25c68e322942eab7754de7e. The host and the
>> interface definition I used for testing are also attached.
>> I would be glad if the patch could be added to the repo.
> 
> Great !
> 
...

> Various whitespace fixes
> 
>  - For assignment, we prefer 'foo = bar' instead of 'foo=bar'
>  - For conditionals  'if (' instead of 'if('
>  - For tests  "foo < 0" instead of "foo<0"
> 
> 
> So all in all I think I'd write this as 
> 
>   int qemuDomainChangeNetBridge(virDomainNetDefPtr olddev,
>                                 virDomainNetDefPtr newdev)
>   {

...

Are you planning on resubmitting this patch with the noted improvements?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]