[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Modified version of the libvirt-test-api wrapper



On 03/16/2012 04:24 AM, Lucas Meneghel Rodrigues wrote:
On 03/14/2012 11:56 AM, Guannan Ren wrote:
On 03/14/2012 06:45 PM, Daniel Veillard wrote:
On Tue, Mar 13, 2012 at 11:05:31PM -0300, Lucas Meneghel Rodrigues wrote:
Hi Guannan:

I've worked on your first version of the libvirt-test-api wrapper
for autotest. Could you please check if you like the modified
version?

https://github.com/autotest/autotest/pull/230

If you do think it's fine, you can ack it, or you might take it,
modify and resend it. On a git branch, you can do the following:

curl https://github.com/autotest/autotest/pull/230.patch | git am

And then modify and resend.
All this looks fine to me. Maybe the libvirt-test-API.tar.gz
should be renamed to stamp it, we should make sure it is recent, and
possibly make a release (that could be as simple as copying one
of
ftp://libvirt.org/libvirt/libvirt-test-API/libvirt-test-API-git-snapshot.tar.gz

and renaming it as libvirt-test-API-0.1.0.tar.gz) and push that to
autotest git instead,

Daniel


I agree with this, for following work,
we could submit patch to autotest mailing list.

Guannan

Ok, so I've commited the wrapper to the upstream repo:

https://github.com/autotest/autotest/commit/c915fa8aea2c6a0542f2d798ad6a0fbaf2738ef3

When you want to follow up with this, let me know.

Cheers,

Lucas

    That's great.
    Thanks.

    Guannan Ren


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]