[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix handling of blkio deviceWeight empty string



On 03/16/2012 05:07 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> A common coding pattern for changing blkio parameters is
> 
>   1. virDomainGetBlkioParameters
> 
>   2. change one or more params
> 
>   3. virDomainSetBlkioParameters
> 
> For this to work, it must be possible to roundtrip through
> the methods without error. Unforuntelty virDomainGetBlkioParameters

s/Unforuntelty/Unfortunately/

> will return "" for the deviceWeight parameter for guests by default,
> which virDomainSetBlkioParameters will then reject as invalid.
> 
> This fixes the handling of "" to be a no-op, and also improves the
> error message to tell you what was invalid
> ---
>  src/qemu/qemu_driver.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]