[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] Fixed NULL pointer check



On 19.03.2012 11:05, Martin Kletzander wrote:
> This patch fixes a NULL pointer check that was causing SegFault on
> some specific configurations. It also reverts commit 59d0c9801c1ab
> that was checking for this value in one place.
> ---
> v3:
>  - added revert of 59d0c9801c1ab that's not needed anymore
> 
>  - (comment) ATTRIBUTE_RETURN_CHECK not added as it is not used with other
>    functions defined in this file and the commit could be confusing modifying
>    all of them together. However, there should be one patch to fix all these
>    at once if possible
> 
> v2:
>  - removed parenthesis around return value
> 
>  src/libvirt.c   |    3 +--
>  src/util/conf.c |    5 ++++-
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 

I've tweaked the patch subject (prepended with 'virConfGetValue: ' for
easier git-log) and pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]