[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Cpu mapping cleanup



On 03/19/2012 06:29 AM, Martin Kletzander wrote:
> Using inheritance, this patch cleans up the cpu_map.xml file and also
> sorts all CPU features according to the feature and registry
> values. Model features are sorted the same way as foeatures in the

s/foeatures/features/

> specification.
> Also few models that are related were organized together and parts of
> the XML are marked with comments
> ---
>  src/cpu/cpu_map.xml |  455 +++++++++-----------------------------------------
>  1 files changed, 82 insertions(+), 373 deletions(-)

The inheritance is definitely an improvement for reducing lines of code.
 The patch was a bit hard to read (splitting things into three patches:
reordering options, reordering CPU models into groups, then taking
advantage of inheritance; rather than doing all three actions in one
patch, might have been easier), but seems correct after the few minutes
I've spent on it, and isn't worth the time to respin the series just to
split the patch.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]