[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] python: always include config.h first



On RHEL 5.7, I got this compilation failure:

In file included from /usr/include/python2.4/pyport.h:98,
                 from /usr/include/python2.4/Python.h:55,
                 from libvirt.c:3:
../gnulib/lib/time.h:468: error: expected ';', ',' or ')' before '__timer'

Turns out that our '#define restrict __restrict' from config.h wasn't
being picked up.  Gnulib _requires_ that all .c files include <config.h>
first, otherwise the gnulib header overrides tend to misbehave.

* python/generator.py (buildStubs): Include <config.h> first.
---

Pushing under the build-breaker rule.

 python/generator.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/python/generator.py b/python/generator.py
index 98072f0..e641c31 100755
--- a/python/generator.py
+++ b/python/generator.py
@@ -757,7 +757,8 @@ def buildStubs(module):
     export.write("/* Generated */\n\n")

     wrapper = open(wrapper_file, "w")
-    wrapper.write("/* Generated */\n\n")
+    wrapper.write("/* Generated by generator.py */\n\n")
+    wrapper.write("#include <config.h>\n")
     wrapper.write("#include <Python.h>\n")
     wrapper.write("#include <libvirt/" + module + ".h>\n")
     wrapper.write("#include \"typewrappers.h\"\n")
-- 
1.7.7.6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]