[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] build: drop a painfully long gnulib test



On machines with massive amounts of CPUs, the gnulib 'test-lock'
could take minutes, or even appear to deadlock, because of timing
interactions between multiple cores.

See https://bugzilla.redhat.com/show_bug.cgi?id=797284.
For precedence, note that iwhd has done the same:
https://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00311.html

We can re-enable things if gnulib ever analyzes and improves the
situation.

* bootstrap.conf (gnulib_tool_option_extras): Avoid lock-tests.
---

Personally, I haven't run into the problem on my 2-core laptop;
where do I sign up for one of the 2048-core machines in that BZ? :)
But since I haven't seen it, I can't push this under the trivial
rule, so I'll wait for a review.

 bootstrap.conf |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 03da267..c6f7fd9 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -174,6 +174,7 @@ gnulib_tool_option_extras="\
  --with-tests\
  --makefile-name=gnulib.mk\
  --avoid=pt_chown\
+ --avoid=lock-tests\
 "
 local_gl_dir=gnulib/local

-- 
1.7.7.6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]