[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 12/14] Add APIs for handling lookup of auth credentials from config file



On 03/20/2012 11:33 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> This defines the format for the auth credential config file and
> provides APIs to access the data. The config file contains
> one or more named 'credential' sets
> 
>   [credentials-$NAME]
>   credname1=value1
>   credname2=value2
> 
> eg
> 
>   [credentials-test]
>   authname=fred
>   password=123456

I'm not always a fan of plain-text passwords; do you have plans to
further enhance this to hook into our virSecret design, where the config
file can list the name of a secret to reference, which in turn will
trigger appropriate calls to the virSecret API to grab credentials on
first use, securely caching them for later uses that need the same
credentials but without the drawbacks of plain-text config files?  But
that's future enhancement, and doesn't stop this patch from going in
once you address Osier's review comments.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]