[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] snapshot: wire up qemu transaction command



On 03/22/2012 08:53 AM, Eric Blake wrote:
> On 03/22/2012 08:47 AM, Peter Krempa wrote:
>> On 03/17/2012 10:27 PM, Eric Blake wrote:
>>> The hardest part about adding transactions is not using the new
>>> monitor command, but undoing the partial changes we made prior
>>> to a failed transaction.
>>>
> 

>> I don't have many experience working with the locking and security code,
>> but this funcion looks as it's doing what it should. I'd feel more
>> confident if somebody other would look at this part.
>>
>> ACK to the rest, and a not-so-confident ACK of the marked part if my
>> question gets cleared.

I've folded in the mentioned fixes,

> 
> Thanks for reviewing.  As with round 1, I will delay pushing these until
> I have finished rounds 4 and 5 for the complete mirrored storage
> migration solution, in case I come up with any other last-minute tweaks.

and pushed round 2 now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]