[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Add support for setting init argv for LXC



On 03/26/2012 11:13 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Pass argv to the init binary of LXC, using a new <initarg> element.
> 
> * docs/formatdomain.html.in: Document <os> usage for containers
> * docs/schemas/domaincommon.rng: Add <initarg> element
> * src/conf/domain_conf.c, src/conf/domain_conf.h: parsing and
>   formatting of <initarg>
> * src/lxc/lxc_container.c: Setup LXC argv
> * tests/Makefile.am, tests/lxcxml2xmldata/lxc-systemd.xml,
>   tests/lxcxml2xmltest.c, tests/testutilslxc.c,
>   tests/testutilslxc.h: Test parsing/formatting of LXC related
>   XML parts
> ---
>  docs/formatdomain.html.in            |   22 +++++
>  docs/schemas/domaincommon.rng        |    5 +
>  src/conf/domain_conf.c               |   28 ++++++-
>  src/conf/domain_conf.h               |    1 +
>  src/lxc/lxc_container.c              |    3 +
>  tests/Makefile.am                    |   21 +++++
>  tests/lxcxml2xmldata/lxc-systemd.xml |   30 +++++++
>  tests/lxcxml2xmltest.c               |  141 ++++++++++++++++++++++++++++++++++
>  tests/testutilslxc.c                 |   63 +++++++++++++++
>  tests/testutilslxc.h                 |    4 +
>  10 files changed, 316 insertions(+), 2 deletions(-)
>  create mode 100644 tests/lxcxml2xmldata/lxc-systemd.xml
>  create mode 100644 tests/lxcxml2xmltest.c
>  create mode 100644 tests/testutilslxc.c
>  create mode 100644 tests/testutilslxc.h

Nice - docs and tests all in one patch.  The test worked for me when I
applied it to my local tree.

ACK; I'll let you push it with your other pending patches.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]