[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Enable build of test suite programs by default for GIT checkouts



On 03/27/2012 09:37 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Add a new flag '--with-test-suite' to configure to control whether
> the test suite binaries are built by default. ie built with a
> plain 'make', as opposed to delayed until 'make check'
> 
> For builds from tar.gz tests will not be built by default. For
> builds from GIT, tests with be on by default, to try and ensure
> that patch developers don't accidentally break the test suites
> without noticing.
> 
> * configure.ac: Add --with-test-suite
> * tests/Makefile.am: Use noinst_PROGRAMS instead of check_PROGRAMS
>   if building tests by default. Consolidate setting of TESTS and
>   {noinst,check}_PROGRAMS to avoid duplication
> ---
>  configure.ac      |   19 ++++++++
>  tests/Makefile.am |  119 +++++++++++++---------------------------------------
>  2 files changed, 49 insertions(+), 89 deletions(-)

Nice refactoring.  ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]