[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Enable all warnings permanently & default to -Werror for GIT builds



On 03/27/2012 09:50 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Given that we auto-detect whether each -Wxxxx flag is supported by
> GCC, and we are warning-free and use automake silent rules, there
> is no compelling reason to allow compile warnings to be disabled.
> 
> Replace the --enable-compile-warnings flag with a simpler
> --enable-werror flag, which defaults to 'yes' if building
> from GIT, or 'no' if building from tar.gz
> 
> This helps ensure that everyone writing patches for libvirt will
> take care to fix their warning problems before submitting for
> review
> 
> * autobuild.sh: Force -Werror
> * configure.ac: Update for LIBVIRT_COMPILE_WARNINGS macro change
> * m4/virt-compile-warnings.m4: Permanently enable all warnings,
>   auto-enable Werror for GIT builds
> ---
>  autobuild.sh                |    4 +-
>  configure.ac                |    4 +-
>  m4/virt-compile-warnings.m4 |  258 +++++++++++++++++++++----------------------
>  3 files changed, 130 insertions(+), 136 deletions(-)

ACK.  Most of this was an indentation change; the 'git diff -b' view
makes it easier to review.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]