[libvirt] [PATCH] Re: Turning off libvirtd mdns by default

[Stef Walter]

On 2012-03-27 17:59, Eric Blake wrote:
> On 03/27/2012 08:20 AM, Stef Walter wrote:
>>
>> > From ef831d7c35871f26964742ca1de49ef464dd7bbb Mon Sep 17 00:00:00 2001
>> From: Stef Walter<stefw at gnome.org>
>> Date: Tue, 27 Mar 2012 13:59:07 +0200
>> Subject: [PATCH] Change the default of mdns_adv to false
>>
>>   * Don't advertise information on the network without consent of
>>     the user, either through manual configuration, or a user
>>     interface that drives this option.
>>   * Since libvirtd must be configured for network access anyway
>>     this setting was not useful "out of the box", so changing this
>>     default setting does not remove "out of the box" functionality.
>
> I tweaked this wording slightly, since ssh access doesn't need tweaking;
> but agree with the patch in general.
>
>> ---
>>   daemon/libvirtd.c            |    2 +-
>>   daemon/libvirtd.conf         |    4 ++--
>>   daemon/test_libvirtd.aug     |    8 ++++----
>>   docs/remote.html.in          |    2 +-
>>   tests/confdata/libvirtd.conf |    4 ++--
>>   tests/confdata/libvirtd.out  |    4 ++--
>>   6 files changed, 12 insertions(+), 12 deletions(-)
>
> ACK.  I've added your name to AUTHORS, and pushed the patch.  Let me
> know if you prefer an alternate spelling.

Thanks! Much appreciated.

Cheers,

Stef