[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] snapshot: fix virsh docs



On 03/28/2012 10:25 AM, Eric Blake wrote:
Commit d42a2ff forgot to touch up virsh documentation, and commit
4e9953a mis-spelled the option name.

* tools/virsh.pod (snapshot-create, snapshot-create-as): Fix typo
and match recent change in flag meaning.
---
  tools/virsh.pod |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index 390bcec..76d2ea4 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -2347,7 +2347,7 @@ metadata again).

  If I<--reuse-external>  is specified, and the snapshot XML requests an
  external snapshot with a destination of an existing file, then the
-existing file is truncated and reused; otherwise, a snapshot is refused
+destination must exist, and is reused; otherwise, a snapshot is refused
  to avoid losing contents of the existing files.

  If I<--quiesce>  is specified, libvirt will try to use guest agent
@@ -2367,7 +2367,7 @@ metadata is silently lost when the domain quits running (whether
  by command such as B<destroy>  or by internal guest action).

  =item B<snapshot-create-as>  I<domain>  {[I<--print-xml>]
-| [I<--no-metadata>] [I<--halt>] [I<--reuse-existing>]} [I<name>]
+| [I<--no-metadata>] [I<--halt>] [I<--reuse-external>]} [I<name>]
  [I<description>] [I<--disk-only>  [I<--quiesce>] [I<--atomic>]
  [[I<--diskspec>] B<diskspec>]...]

@@ -2394,7 +2394,7 @@ results in the following XML:

  If I<--reuse-external>  is specified, and the domain XML or I<diskspec>
  option requests an external snapshot with a destination of an existing
-file, then the existing file is truncated and reused; otherwise, a
+file, then the destination must exist, and is reused; otherwise, a
  snapshot is refused to avoid losing contents of the existing files.

  If I<--quiesce>  is specified, libvirt will try to use guest agent

ACK


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]