[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] Don't redefine the CPU comparison constants in CPU test



On 03/29/2012 05:53 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
>
> Defining an enum with names like "ERROR" causes  a world of
> hurt on Win32 whose headers have such symbol names already
>
> * tests/cputest.c: Remove redefinition of CPU constants
>
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  tests/cputest.c |   75 +++++++++++++++++++++++++------------------------------
>  1 files changed, 34 insertions(+), 41 deletions(-)
>
> diff --git a/tests/cputest.c b/tests/cputest.c
> index 6c1efe6..9928e5d 100644
> --- a/tests/cputest.c
> +++ b/tests/cputest.c
> @@ -43,13 +43,6 @@ static const char *abs_top_srcdir;
>  
>  #define VIR_FROM_THIS VIR_FROM_CPU
>  
> -enum compResultShadow {
> -    ERROR           = VIR_CPU_COMPARE_ERROR,
> -    INCOMPATIBLE    = VIR_CPU_COMPARE_INCOMPATIBLE,
> -    IDENTICAL       = VIR_CPU_COMPARE_IDENTICAL,
> -    SUPERSET        = VIR_CPU_COMPARE_SUPERSET
> -};
> -

Why was this done to begin with? To save typing/columns?

At any rate, ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]