[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] Fix format specifiers in test cases on Win32



On Thu, Mar 29, 2012 at 06:45:03AM -0600, Eric Blake wrote:
> On 03/29/2012 03:53 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > Some of the test suites use fprintf with format specifiers
> > that are not supported on Win32 and are not fixed by gnulib.
> > 
> > The mingw32 compiler also has trouble detecting ssize_t
> > correctly, complaining that 'ssize_t' does not match
> > 'signed size_t' (which it expects for %zd). Force the
> > cast to size_t to avoid this problem
> 
> Nothing wrong with your libvirt patch, but I can't help wonder if this
> is a bug in the gnulib replacement headers, where mingw lacks ssize_t
> but gnulib defines it to the wrong type in comparison to size_t (that
> is, since mingw64 has sizeof(size_t)==4, it is not obvious whether
> size_t is 'unsigned long' or 'unsigned int', and if gnulib picked 'int'
> for ssize_t but size_t is 'unsigned long', that would explain the
> compiler warnings.  Gnulib may need to be tweaked to help work around
> this mingw situation.

Ah, if it turns out to be a gnulib bug, then that'd be
preferrable to fix.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]