[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virnetdevtap: Don't check for flags in virNetDevTapCreateFlags



On 30.03.2012 15:04, Eric Blake wrote:
> On 03/30/2012 05:49 AM, Michal Privoznik wrote:
>> With latest gnulib we are checking even the lowest level functions
>> whether they check flags. Moreover, we are shadowing the real error
>> on system without TUNSETIFF support.
>> ---
>>  cfg.mk                  |    2 +-
>>  src/util/virnetdevtap.c |    5 +----
>>  2 files changed, 2 insertions(+), 5 deletions(-)
>>
> 
>> @@ -241,7 +239,6 @@ int virNetDevTapCreate(char **ifname ATTRIBUTE_UNUSED,
>>                         int *tapfd ATTRIBUTE_UNUSED,
>>                         unsigned int flags)
> 
> Missing the ATTRIBUTE_UNUSED here.  ACK with that fix.
> 

Yeah, my in brain git-revert has some defects :)

Pushed, thanks.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]