[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/3]usb devices with same vendorID, productID hotplug support



On 2012年05月03日 00:35, Eric Blake wrote:
On 05/02/2012 10:26 AM, Osier Yang wrote:

The error could be more clear, e.g.

multiple USB deivces for vendor='15e1',
product='2007', use<address>  to specify one.

And it's not "XML error", the XML is just fine. The XML with
only 'vendor' and 'product' specified could still work well
if no mulitple devices with the same vendor and product.

Perhaps VIR_ERR_INTERNAL_ERROR is a good choice.

No, because it's not an internal libvirt problem, but an ambiguous user
input problem.  I'd recommend VIR_ERR_INVALID_ARG (invalid because it
was ambiguous) or VIR_ERR_OPERATION_FAILED (failed because we didn't
have enough information).


I considered VIR_ERR_OPERATION_FAILED too, so +1 for it, :-)

Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]