[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt 1/3] build: do not build shunloadtest if pthread missing



On 05/02/2012 12:38 PM, Eric Blake wrote:
> On 05/02/2012 09:16 AM, Daniel P. Berrange wrote:
>> On Wed, May 02, 2012 at 04:57:41PM +0200, Marc-André Lureau wrote:
>>> ping
>>>
> 
>>
>> ACK, even though it is possible to have pthreads on Windows, libvirt
>> is designed to use native windows threading instead.
> 
> Pushed, and I will review the others in the series as well.

Scratch that, it fails 'make syntax-check':

prohibit_always_true_header_tests
configure.ac:157:AM_CONDITIONAL([HAVE_PTHREAD], [test x"$HAVE_PTHREAD_H"
= x"1"])
maint.mk: do not test the above HAVE_<header>_H symbol(s);
  with the corresponding gnulib module, they are always true
make: *** [sc_prohibit_always_true_header_tests] Error 1

Rather, we should be using the same conditional as threads.h; namely
#ifdef WIN32.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]