[libvirt] [PATCH V1 1/5] vmx: fix resource leak

[Osier Yang]

On 2012年05月04日 19:54, Stefan Berger wrote:
> Error: RESOURCE_LEAK:
> /libvirt/src/vmx/vmx.c:2431:
> alloc_fn: Calling allocation function "calloc".
> /libvirt/src/vmx/vmx.c:2431:
> var_assign: Assigning: "networkName" =  storage returned from "calloc(1UL, 1UL)".
> /libvirt/src/vmx/vmx.c:2495:
> leaked_storage: Variable "networkName" going out of scope leaks the storage it points to.
>
> ---
>   src/vmx/vmx.c |    1 +
>   1 file changed, 1 insertion(+)
>
> Index: libvirt-acl/src/vmx/vmx.c
> ===================================================================
> --- libvirt-acl.orig/src/vmx/vmx.c
> +++ libvirt-acl/src/vmx/vmx.c
> @@ -2485,6 +2485,7 @@ virVMXParseEthernet(virConfPtr conf, int
>           *def = NULL;
>       }
>
> +    VIR_FREE(networkName);
>       VIR_FREE(connectionType);
>       VIR_FREE(addressType);
>       VIR_FREE(generatedAddress);

ACK

Osier